Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix new rolling stock categories not reseting #11046

Merged
merged 1 commit into from
Mar 6, 2025
Merged

front: fix new rolling stock categories not reseting #11046

merged 1 commit into from
Mar 6, 2025

Conversation

Synar
Copy link
Contributor

@Synar Synar commented Mar 6, 2025

Close #11024

@Synar Synar requested a review from a team as a code owner March 6, 2025 12:15
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (164c697) to head (c6b9cc5).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #11046      +/-   ##
==========================================
- Coverage   80.63%   80.63%   -0.01%     
==========================================
  Files        1099     1101       +2     
  Lines      112187   112323     +136     
  Branches      745      749       +4     
==========================================
+ Hits        90460    90567     +107     
- Misses      21684    21713      +29     
  Partials       43       43
Flag Coverage Δ
editoast 72.18% <ø> (ø)
front 89.92% <100.00%> (-0.03%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

louisgreiner
louisgreiner approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working great ! Thanks :-)

SharglutDev
SharglutDev approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested ✅

@Synar Synar enabled auto-merge March 6, 2025 14:19
@Synar Synar added this pull request to the merge queue Mar 6, 2025
Merged via the queue into dev with commit df5b523 Mar 6, 2025
27 checks passed
@Synar Synar deleted the ali/fix-new-rolling-stock-categories-front branch March 6, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgreiner louisgreiner louisgreiner approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: other categories field isn't reset in rs editor
4 participants
@Synar @codecov-commenter @louisgreiner @SharglutDev